Preserve metadata on fn and action macros #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because they're macros, rx/fn and rx/action would lose metadata attached to them, in particular type hints which are slightly important to disambiguate overloaded Observable methods. Fixed.
|
RxJava-pull-requests #211 FAILURE |
|
What normal use cases with Observable need type hints? |
benjchristensen
added a commit
that referenced
this pull request
Aug 31, 2013
Preserve metadata on fn and action macros
|
@benjchristensen only to disambiguate an overloaded method. So, for 0.11.0, almost never, as far as I can tell. This is the result of further backporting the interop stuff into a 0.10 system where the |
|
I hope we can avoid ambiguous method signatures, as it would cause problems for other languages as well such as Groovy. I just released 0.11.1 to pick up this change. |
|
Me too. Aren't you worried about running out of version numbers if you keep releasing so often? :) |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Preserve metadata on fn and action macros
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because they're macros, rx/fn and rx/action would lose metadata attached
to them, in particular type hints which are slightly important to
disambiguate overloaded Observable methods. Fixed.