Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OperationSwitch notify onComplete() too early. #443

Merged
merged 3 commits into from
Oct 22, 2013
Merged

OperationSwitch notify onComplete() too early. #443

merged 3 commits into from
Oct 22, 2013

Conversation

ylecaillez
Copy link
Contributor

OperationSwitch has to wait that both parent and child complete before complete itself.

@ylecaillez
Copy link
Contributor Author

Patch is mostly a port of https://github.com/Reactive-Extensions/Rx.NET/blob/master/Rx.NET/Source/System.Reactive.Linq/Reactive/Linq/Observable/Switch.cs

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #363 FAILURE
Looks like there's a problem with this pull request

@ylecaillez
Do not unsubscribe from child once parent has been completed.
d48e92f 
Child should not be unsubscribed when the parent complete because it may not be completed.
@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #364 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member

Thank you @ylecaillez

benjchristensen added a commit that referenced this pull request Oct 22, 2013
@benjchristensen
Merge pull request #443 from ylecaillez/master
132f925 
OperationSwitch notify onComplete() too early.
@benjchristensen benjchristensen merged commit 132f925 into ReactiveX:master Oct 22, 2013
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
@benjchristensen
Merge pull request ReactiveX#443 from ylecaillez/master
2dc5240 
OperationSwitch notify onComplete() too early.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ylecaillez @cloudbees-pull-request-builder @benjchristensen