Creating Observables in Scala: Approach04 #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and move Java types <=> Scala types conversions from ImplicitFunctionConversions to JavaConversions
|
RxJava-pull-requests #488 SUCCESS |
|
Is this a breaking change for Scala? |
|
Yes |
|
This needs to be rebased. Since this is breaking, it makes sense to merge before releasing 0.16.0 with the other breaking Scala changes. I would appreciate if you provided release notes for this and the other breaking Scala changes to include when I release 0.16.0. |
…a-constructors Conflicts: language-adaptors/rxjava-scala/src/examples/scala/rx/lang/scala/examples/RxScalaDemo.scala language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/ImplicitFunctionConversions.scala language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Observable.scala
|
rebasing done |
|
RxJava-pull-requests #494 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Dec 5, 2013
Creating Observables in Scala: Approach04
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Creating Observables in Scala: Approach04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements approach04 from #549 .
I also moved the
toScalaXxx/toJavaXxxmethods into a separate file, so that one can import only these without importing the implicit function conversions.There's now also
Observable.from(Future)and to test it, some tweaks inNotificationwere necessary.Note that this is a breaking change.