Scala Adaptor Improvements by Erik #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the other subscriptions
Added overload for zip
Added scheduler factory.
Scala collections do not have such a function, and we want to be as close to Scala collections as possible
A few trivial Scala adaptor details
Fixed tests, all working without warnings
(a) it will stop the pointless discussions around it. (b) it is removes the interference with from(T*) (c) we should remove the latter, since that is not the common case.
|
RxJava-pull-requests #490 SUCCESS |
|
Are these breaking changes? |
|
Yes |
|
Thanks Samuel, I was waiting for your OK on this. Ben, you want to merge these in so Samuel and I can make progress? |
benjchristensen
added a commit
that referenced
this pull request
Dec 4, 2013
Scala Adaptor Improvements by Erik
|
Are both of you ready for a 0.16.0 release or is more coming before that? Can you give me release notes on breaking changes? |
|
I'll write release notes tonight. Samuel, you want to make a pull request on my branch so I can pull in your changes? I think that still shows up in the RxJava pull request as coming from you (I believe) so that you get the credit you deserve. |
|
Or do it in two steps. |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Scala Adaptor Improvements by Erik
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…ansition happens * Issue ReactiveX#562: State transition must be validated before the transition happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many important improvements by Erik on the branch https://github.com/Applied-Duality/RxJava/tree/RxJavaBugFixes , and I'd like to have them on Netflix:master, so that everyone works on the same code, and that we can avoid duplicate work, since some changes I'd like to do require changes that Erik has already made. @headinthebox hope you're ok with this.