Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation Sample with Observable v2 #571

Merged
merged 1 commit into from
Dec 8, 2013

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 6, 2013

Issue #74

  • Sample will terminate if either the source or the sampler terminates or throws an error.
  • The sampler now emits values only in its onNext() method. Therefore, if the sampler completes and there is a sampled value available (valueTaken == false), it won't emit the value before terminating.

@cloudbees-pull-request-builder

RxJava-pull-requests #506 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request Dec 8, 2013
Operation Sample with Observable v2
@benjchristensen benjchristensen merged commit 53787f2 into ReactiveX:master Dec 8, 2013
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
@akarnokd akarnokd deleted the SampleWithObservable2 branch January 13, 2014 10:03
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants