Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay additional overloads #612

Merged
merged 2 commits into from
Dec 12, 2013

Conversation

akarnokd
Copy link
Member

Issue #71

  • Added several overloads of the replay operator:
    • limited buffer, limited time window, buffer+time,
    • scheduler overloads;
    • versions which perform a projection before the replay
  • Added missing multicast overload

benjchristensen added a commit that referenced this pull request Dec 12, 2013
@benjchristensen benjchristensen merged commit e4bd5dd into ReactiveX:master Dec 12, 2013
@cloudbees-pull-request-builder

RxJava-pull-requests #548 SUCCESS
This pull request looks good

@DavidMGross
Copy link
Collaborator

Could you give me an explanation of what the "selector" does and why it's
useful, and also what the version of replay that uses a subject factory is
all about? The javadocs are opaque to me and the MSDN docs / Intro-to-Rx
aren't helpful either.

On Thu, Dec 12, 2013 at 12:53 PM, CloudBees pull request builder plugin <
notifications@github.com> wrote:

RxJava-pull-requests #548https://netflixoss.ci.cloudbees.com/job/RxJava-pull-requests/548/SUCCESS
This pull request looks good


Reply to this email directly or view it on GitHubhttps://github.com//pull/612#issuecomment-30460606
.

David M. Gross
PLP Consulting

@akarnokd
Copy link
Member Author

I'm not sure myself. I think it allows transforming the subject's output without the danger of resubscribing to the uplink source. I couldn't find any tests for them in the Rx.NET sources.

rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
@akarnokd akarnokd deleted the ReplayAdditionalOps branch January 13, 2014 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants