SerialSubscription & From #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…underlying subscription now implements it.
Fixed blocking test in ObservableWindowTest
|
RxJava-pull-requests #555 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Dec 23, 2013
SerialSubscription & From
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
SerialSubscription & From
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
* Make this config explicitly immutable * Explicit doc for config field * Temporary change, to trigger warning from sonar. * Make this config explicitly immutable * Fix few other sonar complaints * Disable non-relevant check in sonar * Remove unused import * Propagate right info about thread interruption to callers via exceptions and Thread.interrupted flag * Fixes after merge with master * Additional tests and code cleanup * Tests fix * Update documentation about thread interruption contract. Update release notes. * Make common exception type for RateLimiter and Bulkhead * Code review comments fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scala bindings for SerialSubscription since underlying type now implements isUnsubscribed.
Changed Observable.from to use currentThreadScheduler (principle of least surprise).
Used scheduler in create instead of observerOn.
Fixed blocking tests.