Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operators DelaySubscription, TakeLast w/ time, TakeLastBuffer #638

Merged
merged 1 commit into from
Dec 23, 2013
Merged

Operators DelaySubscription, TakeLast w/ time, TakeLastBuffer #638

merged 1 commit into from
Dec 23, 2013

Conversation

akarnokd
Copy link
Member

Issue #634

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #567 SUCCESS
This pull request looks good

@zsxwing zsxwing mentioned this pull request Dec 20, 2013
Closed
53 tasks
@benjchristensen
Copy link
Member

This looks good ... merging.

Two requests going forward though.

  1. Please do not mix different operators into a single pull request that are not related. The delaySubscription and take* operators have nothing to do with each other and confused the review.
  2. When you add method signatures that Rx.Net does not have it would be helpful for you to call them out.

Thank you!

benjchristensen added a commit that referenced this pull request Dec 23, 2013
@benjchristensen
Merge pull request #638 from akarnokd/OperationTakeLastwBufferDeferSu…
c9be48c 
…bscr

Operators DelaySubscription, TakeLast w/ time, TakeLastBuffer
@benjchristensen benjchristensen merged commit c9be48c into ReactiveX:master Dec 23, 2013
@akarnokd
Copy link
Member Author

Will separate unrelated ops from now on.

@benjchristensen benjchristensen mentioned this pull request Jan 7, 2014
Closed
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
@benjchristensen
Merge pull request ReactiveX#638 from akarnokd/OperationTakeLastwBuff…
0c8389c 
…erDeferSubscr

Operators DelaySubscription, TakeLast w/ time, TakeLastBuffer
@akarnokd akarnokd deleted the OperationTakeLastwBufferDeferSubscr branch January 13, 2014 09:59
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
@hexmind @RobWin
Remove javax.xml.ws.WebServiceException (ReactiveX#638)
42b3a04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akarnokd @cloudbees-pull-request-builder @benjchristensen