Fix SafeObserver handling of onComplete errors #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjchristensen
added a commit
that referenced
this pull request
Dec 24, 2013
Fix SafeObserver handling of onComplete errors
|
RxJava-pull-requests #605 FAILURE |
|
So the contract becomes |
|
Not really. This is handling out of contract scenarios. A proper observer should never fail on any of these notifications thus SafeObserver logic should never apply, but bugs exist and this is all about making a system operational despite code not complying with the Rx contract and having bugs. |
|
Got it. Thanks! |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
…rorHandling Fix SafeObserver handling of onComplete errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630