Added Observable.timeout wrappers to scala adapter
#720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the four timeout methods on Observable in the Scala adaptor. Note for the java/scala type interop: http://stackoverflow.com/q/20912151
|
Scala novice here. This is untested and needs review. |
|
RxJava-pull-requests #637 SUCCESS |
|
I'll have a look; I will be looking at all missing operators in the Scala bindings in the next couple of days. |
|
LGTM, thanks @hura for contributing |
|
You're welcome. Thanks for clarifying my questions on stackoverflow. Now everything is clear and makes sense. Cheers |
|
Yup. I see no problems. |
|
Merging based on last comment by @headinthebox and review by @samuelgruetter Thanks @hura |
benjchristensen
added a commit
that referenced
this pull request
Jan 9, 2014
Added `Observable.timeout` wrappers to scala adapter
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the four timeout methods on Observable in the Scala adaptor. Note
for the java/scala type interop:
http://stackoverflow.com/q/20912151