Revert use of CurrentThreadScheduler for Observable.from #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ImmediateScheduler as performance is 4x faster and CurrentThreadScheduler currently offers no benefit (it doesn’t solve the unsubscribe problem).
Performance numbers:
* Observable.from(Arrays.asList(1L, 2L, 3L, 4L, 5L, 6L, 7L, 8L, 9L, 10L), scheduler);
*
* --- Schedulers.immediate() ---
*
* Run: 0 - 1,849,947 ops/sec
* Run: 1 - 2,076,067 ops/sec
* Run: 2 - 2,114,688 ops/sec
* Run: 3 - 2,114,301 ops/sec
* Run: 4 - 2,102,543 ops/sec
*
* --- Schedulers.currentThread() ---
*
* Run: 0 - 548,862 ops/sec
* Run: 1 - 559,955 ops/sec
* Run: 2 - 581,412 ops/sec
* Run: 3 - 562,187 ops/sec
* Run: 4 - 565,723 ops/sec
* Observable.from(Arrays.asList(1L), scheduler);
*
* --- Schedulers.immediate() ---
*
* Run: 10 - 4,113,672 ops/sec
* Run: 11 - 4,068,351 ops/sec
* Run: 12 - 4,070,318 ops/sec
* Run: 13 - 4,161,793 ops/sec
* Run: 14 - 4,156,725 ops/sec
*
* --- Schedulers.currentThread() ---
*
* Run: 10 - 1,692,286 ops/sec
* Run: 11 - 1,765,054 ops/sec
* Run: 12 - 1,763,100 ops/sec
* Run: 13 - 1,770,907 ops/sec
* Run: 14 - 1,732,291 ops/sec
mattrjacobs
added a commit
that referenced
this pull request
Jan 6, 2014
…heduler-usage Revert use of CurrentThreadScheduler for Observable.from
|
RxJava-pull-requests #639 ABORTED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ImmediateScheduler as performance is 4x faster and CurrentThreadScheduler currently offers no benefit (it doesn’t solve the unsubscribe problem).
Performance numbers: