Fixed OperationSubscribeOn so OperationConditionalsTest works again. #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #734 SUCCESS |
|
Interesting, thanks for catching that. I'm sure we'll find a few more of these types of things after my touching basically every class in the codebase. |
benjchristensen
added a commit
that referenced
this pull request
Feb 5, 2014
Fixed OperationSubscribeOn so OperationConditionalsTest works again.
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…unter (ReactiveX#812) In fact under the hood it is a change from Gauge to FunctionCounter which better represents this metric as it constantly grows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commenting out the inner makes the
OperationConditionalsTestpass.Unfortunately, I'm not sure whether this change affects non-Trampolined schedulers in any way or why was there a need to unsubscribe an inner scheduler. It is possible the actual bug is in TrampolineScheduler.