Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One global onCompleted object #816

Merged
merged 1 commit into from
Feb 5, 2014

Conversation

samuelgruetter
Copy link
Contributor

issue #662

@cloudbees-pull-request-builder

RxJava-pull-requests #736 FAILURE
Looks like there's a problem with this pull request

@samuelgruetter
Copy link
Contributor Author

The failing tests are

rx.operators.OperationConditionalsTest.testDoWhileManyTimes
rx.operators.OperationConditionalsTest.testWhileDoManyTimes

and they already failed on my machine before I made any changes.

@benjchristensen
Copy link
Member

Curious, what performance/memory gains does this represent? OnCompleted by definition happens only once per Observable so it's negligible compared with the cost of wrapping T with Notification.

@samuelgruetter
Copy link
Contributor Author

Yes, I think the performance/memory gains are very small [but > 0 ;-) ]. Maybe if someone uses Observables which emit 0 elements and just an OnCompleted to represent durations (e.g. for join), and many of these Observables are materialized, the gains could be somewhat bigger.

@benjchristensen
Copy link
Member

Okay :-)

benjchristensen added a commit that referenced this pull request Feb 5, 2014
@benjchristensen benjchristensen merged commit 64f20f9 into ReactiveX:master Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants