CompositeSubscription performance increase #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
akarnokd
commented
Feb 5, 2014
akarnokd
commented
- Optimized the case when the composite holds only a single element.
- Replaced Arrays.copyOf with regular arraycopy to avoid the cost of reflective array creation
- Included perf test where I got 32% increase on my i7 4770K
|
RxJava-pull-requests #739 SUCCESS |
|
The things we do for performance :-) Very nice changes. Old code on my machine: Run: 10 - 14,477,981 ops/sec New code: Run: 10 - 20,500,289 ops/sec |
benjchristensen
added a commit
that referenced
this pull request
Feb 5, 2014
CompositeSubscription performance increase
|
Like! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.