[Issue #831] Fix for OperationJoin race condition #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #753 FAILURE |
|
Looks like a problem with the build server's local repo rather than the pull request. Caused by: hudson.plugins.git.GitException: Command "git checkout -b master origin/master" returned status code 1: |
|
RxJava-pull-requests #754 FAILURE |
|
Looks to be passing when I run it on my machine. Thank you for hunting this down and submitting a fix! |
benjchristensen
added a commit
that referenced
this pull request
Feb 7, 2014
[Issue #831] Fix for OperationJoin race condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the race condition outlined in issue #831 .
The join now grabs a copy of the other side's id in the first critical section then won't go higher than that in the iteration of the other side's values (now using entrySet()).