Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range OnSubscribe #841

Merged
merged 2 commits into from
Feb 9, 2014
Merged

Range OnSubscribe #841

merged 2 commits into from
Feb 9, 2014

Conversation

benjchristensen
Copy link
Member

Reimplemented as a simple loop instead of Iterable.

Simpler code gives a performance bump:

     * -- 0.17
     * 
     * Run: 10 - 271,147,198 ops/sec
     * Run: 11 - 274,821,481 ops/sec
     * Run: 12 - 271,632,295 ops/sec
     * Run: 13 - 277,876,014 ops/sec
     * Run: 14 - 274,821,763 ops/sec
     * 
     * -- 0.16.1
     * 
     * Run: 10 - 222,104,280 ops/sec
     * Run: 11 - 224,311,761 ops/sec
     * Run: 12 - 222,999,339 ops/sec
     * Run: 13 - 222,344,174 ops/sec
     * Run: 14 - 225,247,983 ops/sec

benjchristensen added a commit that referenced this pull request Feb 9, 2014
@benjchristensen
Merge pull request #841 from benjchristensen/operator-range
185a575 
Range OnSubscribe
@benjchristensen benjchristensen merged commit 185a575 into ReactiveX:master Feb 9, 2014
@benjchristensen benjchristensen deleted the operator-range branch February 9, 2014 03:25
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
@RobWin
Fixed BulkheadAspect: An ExecutionException is wrapped by a Completio…
22931ca 
…nException, but instead the cause should be wrapped. (ReactiveX#841)

Fixed FixedThreadPoolBulkhead: A CompletionException should not be wrapped inside of another CompletionException.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@benjchristensen