Update CompositeSubscriptionTest.java #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix apparent typo, unsubscription of s2 was not checked and should have been.
|
RxJava-pull-requests #804 SUCCESS |
|
Thanks for the fix! I won't even ask what had you looking that detailed at the test code :-) |
benjchristensen
added a commit
that referenced
this pull request
Feb 14, 2014
Update CompositeSubscriptionTest.java
|
No worries. I was looking at the interaction of CompositeSubscription and OperatorRetry in 0.16.1 for an issue I was having and was perusing the CompositeSubscriptionTest looking at unsubscribe behaviour. I see that you've changed RetryOperator significantly in master so I'll retest my issue with master next week and raise a github issue with a failing unit test if I still have a problem, I suspect Schedulers.trampoline will have me sorted. Thanks for the great library! |
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
* Add at least one assertion to this test case. * Complete the assertion. Warnings removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix apparent typo, unsubscription of s2 was not checked and should have been.