Make Subscriptions of SwingObservable thread-safe #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #815 SUCCESS |
|
Does #890 with the new operator Also, can you rebase it for merge? I missed merging it before conflicts happened. |
|
I prefer my current approach as it can |
|
RxJava-pull-requests #826 FAILURE |
|
This failure is because #885 imports a Java 7 api: |
|
RxJava-pull-requests #830 SUCCESS |
Agreed. |
benjchristensen
added a commit
that referenced
this pull request
Feb 18, 2014
Make Subscriptions of SwingObservable thread-safe
samuelgruetter
added a commit
to samuelgruetter/rx-playground
that referenced
this pull request
Sep 14, 2014
noticed the issue thanks to the changes in ReactiveX/RxJava#883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated rxjava-swing according to the discussion in #869. Is it necessary to move the unit tests to src/test/java folder?