add Observable.startWith(Observable) method and unit test #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaking method chaining when want to startWith an Observable rather than just an Iterator or specific values.
|
RxJava-pull-requests #873 FAILURE |
|
Looks like a regression that is unrelated to my pull request. I suspect the involved test is non-deterministic because it assumes that specific asynchronous work is done by the time the line |
…terministic test fails again
|
RxJava-pull-requests #874 SUCCESS |
|
as suspected the failing test is non-deterministic and nothing to do with this pull request. I'll raise an issue. |
benjchristensen
added a commit
that referenced
this pull request
Mar 6, 2014
add Observable.startWith(Observable) method and unit test
|
Looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Observable.startWith(Observable) method and unit test.
I would like to avoid breaking method chaining when want to startWith an Observable rather than just an Iterator or specific values. This is a very minor change as under the covers startWith uses concat anyway but it is significant in terms of code readability and is a natural completion of the startWith api.