Skip to content
This repository has been archived by the owner on Mar 4, 2021. It is now read-only.

Added the ability to fine-tune the probability on a per-ASG basis. #228

Merged
merged 4 commits into from
Jan 4, 2016

Conversation

jeffggardner
Copy link

Because not all ASG are created equally, we needed a way to tune the killing of instances and didn't want to add an entry in chaos.properties for every new ASG. This PR allows you to add a tag to your ASG with the key "chaosMonkey.aggressionCoefficient" and that value will be multiplied by your effective probability for that ASG. For example if my ASG effective probability is 0.5, I can tag my Cassandra ASG's [as an example] with chaosMonkey.aggressionCoefficient=0.5 so that my Cassandra ASG's will have an effective probability of 0.25.

@cloudbees-pull-request-builder

NetflixOSS » SimianArmy » SimianArmy-pull-requests #43 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

SimianArmy-pull-requests #215 SUCCESS
This pull request looks good

@ebukoski
Copy link
Contributor

@lorin This is Chaos Monkey specific so you might want to review.

@jeffggardner
Copy link
Author

any chance I could get a review @lorin ?

thanks

@lorin
Copy link
Contributor

lorin commented Jan 4, 2016

@jeffggardner Apologies for the delays in the review. I noticed a couple of very small issues (a typo and a question), I wrote those as comments on the commit.

Once those are addressed, should be good to go.

@cloudbees-pull-request-builder

NetflixOSS » SimianArmy » SimianArmy-pull-requests #45 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

SimianArmy-pull-requests #217 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

SimianArmy-pull-requests #218 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

NetflixOSS » SimianArmy » SimianArmy-pull-requests #46 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

NetflixOSS » SimianArmy » SimianArmy-pull-requests #47 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

SimianArmy-pull-requests #219 SUCCESS
This pull request looks good

@jeffggardner
Copy link
Author

@lorin Hey Lorin, thanks for the review. I corrected the code per your comments.

lorin added a commit that referenced this pull request Jan 4, 2016
Added the ability to fine-tune the probability on a per-ASG basis.
@lorin lorin merged commit e604bc6 into Netflix:master Jan 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants