Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency conflict for issue #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dependency conflict for issue #99

wants to merge 1 commit into from
+5 −5

Conversation

NeolithEra
Copy link

@NeolithEra NeolithEra commented Jul 24, 2019 •
edited
Loading

#98 keep the consistency between setup.py and requirements.txt

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.723% when pulling 3d6e6c7 on NeolithEra:master into 80f3c1b on Netflix:master.

@NeolithEra
Copy link
Author

@russell-lewis BTW, dependency conflict problems are very common in practice in python ecosystem.
I have encountered the issues several times. What's your oppinion on the challenges of detecting and repairing such issues?
And how to avoid dependency conflict problems among python projects, especially for python library ecosystem?

ghost
ghost approved these changes Oct 9, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the issue

@vanmanhpro
Copy link

This saves the day, the master branch is not working for me at the moment

stoggi added a commit to stoggi/bless that referenced this pull request Nov 4, 2019
@stoggi
Fix marshmellow verison, and prevent jose from verifying access token…
24af4b4 
… hash

* Pin marshmellow to a version less than 3. This might be fixed in Netflix#99
* Disable at_hash verification if present in the JWT, since the bless lambda doesn't have access to the a hash of the access token.
@marcoreni
Copy link

Is it possible to merge this? Master is not working otherwise.

@RossRichardson
Copy link

A workaround for this is pip install -r requirements.txt before any pip install -e .

@oscarnevarezleal
Copy link

I don't know if this project is still relevant/maintained but I wanted to tell you a little story about this guy that watched ~1hr video on youtube about how awesome Bless is, plus ~2hr wrapping his head around the idea of Certificate Authorities, because at this point he was oblivious about them, all he knows was private/public keys. Did I mention this guy doesn't have any background in Python? Anyways he continued removing blocker after blocker, almost there he thought then finally after deploying the solution ... he founds it's not working, Master branch is broken! You know where this is going right? Awesome project guys but the main function is broken and if I understand correctly the solution is right there on a PR from last year, so yeah what's up with that?

@russell-lewis
Copy link
Contributor

Install and builds were against pinned versions, which is why travis is still happy. See https://github.com/Netflix/bless#installation-instructions

I've given the list an update, but I've got to archive this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@NeolithEra @coveralls @vanmanhpro @marcoreni @RossRichardson @oscarnevarezleal @russell-lewis