Database migrations for database schema #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem Database setup was a manual process, requiring someone to apply the schema changes manually. Solution Implement automated database migration using rubenv/sql-migrate and go-bindata, so that the database migrations can be packaged in the same binary. Also added a new command option to apply the migration changes from command line. Result Database schema changes can be applied automatically. "
syamantm
commented
Oct 30, 2016
| @@ -18,7 +18,7 @@ install: | |||
| # | |||
| script: | |||
| - diff -u <(echo -n) <(gofmt -d `find . -name '*.go' | grep -v /vendor/`) | |||
| - go list ./... | grep -v /vendor/ | xargs -L1 golint | |||
| - go list ./... | grep -Ev '/vendor/|/migration' | xargs -L1 golint | |||
There was a problem hiding this comment.
/migration contains the generated file from go-bindata which doesn't adhere to linting rules
|
Thanks for the contribution! I have updated the wiki with info on how to use the new migrate command. |
|
Fixes #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed solution for #9
Implemented automated database migration using sql-migrate and go-bindata, so that the database migrations can be packaged in the same binary. Also added a new command option to
apply the migration changes from command line.
This effectively makes https://github.com/Netflix/chaosmonkey/tree/master/mysql_schema redundant, but I din't want to delete it given that it is still referred in the wiki and therefore is a breaking change.
Happy to open another PR to delete https://github.com/Netflix/chaosmonkey/tree/master/mysql_schema once the new approach is reflected in the wiki(which I can't do unfortunately).
Note: Command to generate
migrations.goisgo-bindata -pkg migration -o migration/migrations.go migration/mysql. This command should added in the script to build the binary(if there is one?), and possibly before running the tests, but I'm not sure what travis's policy is on uncommitted files.