Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't drop by half periodically. #174

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

abersnaze
Copy link
Contributor

after talking with @jolynch this section doesn't make sense if the next line bounds the limit between the min/max. #155

mentioned in #72

With AIMD, this works moderately well - eventually the client goes above the rate limit and a request is dropped. The next window, the concurrency is dropped by half, which generally will correspondingly drop the concurrency too, and cause the rate limit to be missed.

tangentially related to issue #147.

@abersnaze abersnaze changed the title don't drop by half for periodically. don't drop by half periodically. Dec 22, 2021
@fedorka fedorka merged commit 6e86611 into Netflix:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants