Add java 17 compatible jakarta servlet module #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umairk79
reviewed
Feb 14, 2023
...arta/src/main/java/com/netflix/concurrency/limits/servlet/ConcurrencyLimitServletFilter.java
Outdated
Show resolved
Hide resolved
peter-janssen
requested review from
umairk79
and removed request for
fedorka
fedorka
approved these changes
Mar 2, 2023
|
Thanks for the contribution! We've added a couple of commits to it via #183 to increase compatibility with older Java versions. We'll merge it under that PR. |
|
@fedorka any idea when this will be released? |
|
We'll release today or early next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the feedback on #181 I've added a separate module called "concurrency-limits-servlet-jakarta". Personally I don't like the name but I haven't been able to come up with anything better. The module is using the jakarta.servlet-api 6.0.0 specification and is compiled to java 17.
I also took the liberty to upgrade the nebula.netflixoss plugin to version 11.1.1 (the latest version had issues for me),
and changed the gradle wrapper distribution version to 7.6.