Restore bytecode compatibility for limiter builders #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umairk79
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
bypassResolver could be declared as a final field? b4e04f2#diff-28bdb4924263304e505dbc60b1344e3c429dfb1577b9d3d9d2b3a2dd97408d96R97
LGTM, approved.
…sLimitResolverInternal final
github-merge-queue bot
pushed a commit
to camunda/camunda
that referenced
this pull request
Mar 28, 2024
…mits-core to v0.5.0 (main) (#17163) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.netflix.concurrency-limits:concurrency-limits-core](https://togithub.com/Netflix/concurrency-limits) | `0.4.2` -> `0.5.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>Netflix/concurrency-limits (com.netflix.concurrency-limits:concurrency-limits-core)</summary> ### [`v0.5.0`](https://togithub.com/Netflix/concurrency-limits/releases/tag/v0.5.0) [Compare Source](https://togithub.com/Netflix/concurrency-limits/compare/v0.4.2...v0.5.0) ##### What's Changed - Add feature to allow calls to be bypassed without altering limiter stater by [@​umairk79](https://togithub.com/umairk79) in [Netflix/concurrency-limits#194 and by [@​fedorka](https://togithub.com/fedorka) in [Netflix/concurrency-limits#197 - Upgrade nebula oss plugin and gradle to latest version by [@​umairk79](https://togithub.com/umairk79) in [Netflix/concurrency-limits#196 **Full Changelog**: Netflix/concurrency-limits@v0.4.1...v0.5.0 ##### Note: the previously released 0.4.2 inadvertently broke binary compatibility in the limiter builders and should not be used. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 6am every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#194 accidentally broke binary compatibility for the limiter builders. This PR restores compatibility by explicitly deferring type-safety responsibility for bypass resolvers to the implementing subclasses.