This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Issue#241 fix AMQPObservableQueue behaviour to return failed message… #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, not successful ones
jcockrill-rq
changed the title
|
This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days. |
|
@v1r3n - could you check and approve this PR please? Currently AMQPObservableQueue is logging a ton of errors when it shouldn't be. This PR has been marked as stale and I cann't remove it. |
v1r3n
approved these changes
Sep 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Fixed
AMQPObservableQueue#ackto correctly implement its interface definition, but returning the unsuccessfully-ack'ed messages and not the successfully ack'ed ones.Issue #241
Alternatives considered
None