Merge pull request #1003 from Netflix/feature/cleanup_batch_service

remove duplicated code
Netflix · Feb 21, 2019 · 1510638 · 1510638
2 parents 0c13e09 + 5cd69f1
commit 1510638
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/core/src/main/java/com/netflix/conductor/service/WorkflowBulkServiceImpl.java b/core/src/main/java/com/netflix/conductor/service/WorkflowBulkServiceImpl.java
@@ -47,10 +47,6 @@ public WorkflowBulkServiceImpl(WorkflowExecutor workflowExecutor) {
     @Service
     public BulkResponse pauseWorkflow(List<String> workflowIds){
 
-        for (String workflowId : workflowIds) {
-            workflowExecutor.pauseWorkflow(workflowId);
-        }
-
         BulkResponse bulkResponse = new BulkResponse();
         for (String workflowId : workflowIds) {
             try {
@@ -74,7 +70,6 @@ public BulkResponse pauseWorkflow(List<String> workflowIds){
     public BulkResponse resumeWorkflow(List<String> workflowIds) {
     BulkResponse bulkResponse = new BulkResponse();
         for (String workflowId : workflowIds) {
-            workflowExecutor.resumeWorkflow(workflowId);
             try {
                 workflowExecutor.resumeWorkflow(workflowId);
                 bulkResponse.appendSuccessResponse(workflowId);
@@ -97,7 +92,6 @@ public BulkResponse resumeWorkflow(List<String> workflowIds) {
     public BulkResponse restart(List<String> workflowIds, boolean useLatestDefinitions) {
     BulkResponse bulkResponse = new BulkResponse();
         for (String workflowId : workflowIds) {
-            workflowExecutor.rewind(workflowId, useLatestDefinitions);
             try {
                 workflowExecutor.rewind(workflowId, useLatestDefinitions);
                 bulkResponse.appendSuccessResponse(workflowId);
@@ -118,7 +112,6 @@ public BulkResponse restart(List<String> workflowIds, boolean useLatestDefinitio
     public BulkResponse retry(List<String> workflowIds) {
     BulkResponse bulkResponse = new BulkResponse();
         for (String workflowId : workflowIds) {
-            workflowExecutor.retry(workflowId);
             try {
                 workflowExecutor.retry(workflowId);
                 bulkResponse.appendSuccessResponse(workflowId);
@@ -140,7 +133,6 @@ public BulkResponse retry(List<String> workflowIds) {
     public BulkResponse terminate(List<String> workflowIds, String reason) {
      BulkResponse bulkResponse = new BulkResponse();
         for (String workflowId : workflowIds) {
-            workflowExecutor.terminateWorkflow(workflowId, reason);
             try {
                 workflowExecutor.terminateWorkflow(workflowId, reason);
                 bulkResponse.appendSuccessResponse(workflowId);