Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Conductor UI - Task Logs tab doesn't scroll down, pagination buttons are unreachable #2877

Closed
marcocrasso opened this issue Mar 25, 2022 · 2 comments
Assignees
Labels
type: bug bugs/ bug fixes UI User Interface bugs and issues

Comments

@marcocrasso
Copy link
Contributor

marcocrasso commented Mar 25, 2022

Describe the bug
When task logs are more than those that fit in the browser window, the UI doesn't scroll down and the user cannot access the pagination buttons.

Details
Conductor version: main branch (at the moment of writing this)
Persistence implementation: Elasticsearch v6 and v7
Queue implementation: Any
Lock: noop_lock
Workflow definition: Any
Task definition: Any
Event handler definition: N/A

To Reproduce
Steps to reproduce the behavior:

  1. start postgres v6 with:
docker run --name conductor_es -d --rm -p 9400:9200 -p 9500:9300 -v $(pwd)/docker/opt/es/data:/usr/share/elasticsearch/data -e "discovery.type=single-node" -e "xpack.security.enabled=false" docker.elastic.co/elasticsearch/elasticsearch:6.8.15
  1. you need a server configured with taskLogResultLimit bigger than 10 (default)
git fetch
git checkout main
git pull
  1. Edit/add into src/main/resources/application.properties next lines:
conductor.indexing.enabled=true
conductor.elasticsearch.url=http://localhost:9400/
conductor.elasticsearch.taskLogResultLimit=30
conductor.elasticsearch.clusterHealthColor=yellow
  1. ./gradlew clean server
  2. start UI (cd ui ; yarn start)
  3. Generate TaskLog. For doing this, there are options. The obvious alternative is to define a wf, with at least one task, and implement one worker that includes TaskLog(s) in the response. That was my case, and I accidentally found this bug. Optionally, you can use the REST API to populate the logs of an executed task "/task-resource/log", I would recommend this which doesn't require to deploy a new "logger" worker.

Expected behavior
UI User should be able to scroll down and access pagination buttons

Screenshots
image

Additional context
Chrome Version 99.0.4844.83 (Official Build) (x86_64)

@marcocrasso marcocrasso added the type: bug bugs/ bug fixes label Mar 25, 2022
@peterlau peterlau self-assigned this Mar 25, 2022
@peterlau peterlau added the UI User Interface bugs and issues label Mar 25, 2022
@peterlau
Copy link
Collaborator

Thanks for the bug report. This has been reproduced and will be patched in the next minor release. (eta next week)

@peterlau
Copy link
Collaborator

Fixed in 3.7.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug bugs/ bug fixes UI User Interface bugs and issues
Projects
None yet
Development

No branches or pull requests

2 participants