This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
python-client: Improve error checks, update readme, add documentation #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ConductorWorker.py` was only checking if worker response was not None. So if the worker was responding with a dict, the error raised would be much harder to understand. For example, a worker that was giving a response without `logs` key in the dict showed an error > Error executing task: 'logs' This MR aims to fix that. Also have updated the kitchensink example in the `README.md` to return the `logs` field, and some typo fixes.
|
Please let me know if The schema on API docs page doesn't mention logs. |
Codecov Report
@@ Coverage Diff @@
## dev #1010 +/- ##
=========================================
Coverage 62.68% 62.68%
Complexity 2605 2605
=========================================
Files 231 231
Lines 13095 13095
Branches 1310 1310
=========================================
Hits 8208 8208
Misses 4160 4160
Partials 727 727Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 2466
💛 - Coveralls |
add logs to execute_4, and add parens for print statement
|
I am not sure why the tests are failing. The second commit only changed the |
samhattangady
changed the title
kishorebanala
approved these changes
Apr 2, 2019
long-64
pushed a commit
to long-64/conductor
that referenced
this pull request
Oct 2, 2019
…ovements python-client: Improve error checks, update readme, add documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConductorWorker.pywas only checking if worker response was not None.So if the worker was responding with a dict, the error raised would be
much harder to understand.
For example, a worker that was giving a response without
logskey inthe dict showed an error
This MR aims to fix that. Also have updated the kitchensink example in
the
README.mdto return thelogsfield, and some typo fixes.