Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

add external storage paths to summary #1036

Merged
merged 1 commit into from Mar 7, 2019

Conversation

apanicker-nflx
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2449

  • 24 of 35 (68.57%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 68.643%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/main/java/com/netflix/conductor/common/run/TaskSummary.java 8 10 80.0%
common/src/main/java/com/netflix/conductor/common/run/WorkflowSummary.java 8 10 80.0%
grpc/src/main/java/com/netflix/conductor/grpc/AbstractProtoMapper.java 8 15 53.33%
Files with Coverage Reduction New Missed Lines %
grpc/src/main/java/com/netflix/conductor/grpc/AbstractProtoMapper.java 9 51.74%
Totals Coverage Status
Change from base Build 2447: -0.004%
Covered Lines: 9183
Relevant Lines: 13378

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #1036 into dev will increase coverage by <.01%.
The diff coverage is 48.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1036      +/-   ##
============================================
+ Coverage     62.63%   62.63%   +<.01%     
- Complexity     2586     2595       +9     
============================================
  Files           229      229              
  Lines         13043    13073      +30     
  Branches       1302     1310       +8     
============================================
+ Hits           8169     8188      +19     
- Misses         4153     4158       +5     
- Partials        721      727       +6
Impacted Files Coverage Δ Complexity Δ
...om/netflix/conductor/grpc/AbstractProtoMapper.java 38.86% <33.33%> (-0.23%) 54 <0> (ø)
.../netflix/conductor/common/run/WorkflowSummary.java 92.68% <60%> (-4.54%) 42 <4> (+4)
.../com/netflix/conductor/common/run/TaskSummary.java 92.68% <60%> (-4.54%) 39 <4> (+4)
.../com/netflix/conductor/grpc/server/GRPCServer.java 92.85% <0%> (+14.28%) 4% <0%> (ø) ⬇️
.../java/com/netflix/conductor/service/Lifecycle.java 60% <0%> (+30%) 3% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d23f9b...c84e8a5. Read the comment docs.

@apanicker-nflx apanicker-nflx merged commit dc6a062 into dev Mar 7, 2019
@apanicker-nflx apanicker-nflx deleted the external_storage_paths_added_to_summary branch March 7, 2019 21:12
long-64 pushed a commit to long-64/conductor that referenced this pull request Oct 2, 2019
…dded_to_summary

add external storage paths to summary
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants