Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Updated gradle server task to use properties files, and minor cleanup. #1037

Merged
merged 1 commit into from Mar 7, 2019

Conversation

kishorebanala
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2453

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.643%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/src/main/java/com/netflix/conductor/bootstrap/Main.java 0 1 0.0%
Totals Coverage Status
Change from base Build 2450: 0.0%
Covered Lines: 9183
Relevant Lines: 13378

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #1037 into dev will increase coverage by 0.64%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1037      +/-   ##
============================================
+ Coverage     62.59%   63.23%   +0.64%     
- Complexity     2594     2724     +130     
============================================
  Files           229      229              
  Lines         13073    13385     +312     
  Branches       1310     1395      +85     
============================================
+ Hits           8183     8464     +281     
- Misses         4163     4189      +26     
- Partials        727      732       +5
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/netflix/conductor/bootstrap/Main.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...tflix/conductor/core/execution/DeciderService.java 85.47% <100%> (ø) 96 <0> (ø) ⬇️
...x/conductor/common/metadata/workflow/TaskType.java 100% <0%> (ø) 5% <0%> (+2%) ⬆️
.../com/netflix/conductor/core/config/CoreModule.java 100% <0%> (ø) 26% <0%> (+8%) ⬆️
...netflix/conductor/core/utils/S3PayloadStorage.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../com/netflix/conductor/common/run/TaskSummary.java 95.08% <0%> (+2.39%) 59% <0%> (+20%) ⬆️
.../netflix/conductor/common/run/WorkflowSummary.java 95.12% <0%> (+2.43%) 78% <0%> (+36%) ⬆️
...nductor/common/metadata/workflow/WorkflowTask.java 73.29% <0%> (+4.87%) 144% <0%> (+60%) ⬆️
...om/netflix/conductor/grpc/AbstractProtoMapper.java 45.17% <0%> (+6.31%) 58% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc6a062...cf1c820. Read the comment docs.

@kishorebanala kishorebanala merged commit 4bd147c into dev Mar 7, 2019
@apanicker-nflx apanicker-nflx deleted the minor_cleanup_and_refactoring branch March 8, 2019 00:31
long-64 pushed a commit to long-64/conductor that referenced this pull request Oct 2, 2019
…oring

Updated gradle server task to use properties files, and minor cleanup.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants