Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

add async complete option to tasks EVENT and HTTP #1125

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

milongapau
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #1125 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1125      +/-   ##
============================================
+ Coverage     63.11%   63.12%   +<.01%     
- Complexity     2642     2647       +5     
============================================
  Files           233      233              
  Lines         13218    13243      +25     
  Branches       1323     1328       +5     
============================================
+ Hits           8343     8359      +16     
- Misses         4153     4159       +6     
- Partials        722      725       +3
Impacted Files Coverage Δ Complexity Δ
.../com/netflix/conductor/contribs/http/HttpTask.java 64.74% <100%> (+0.45%) 18 <0> (+1) ⬆️
...nductor/core/execution/mapper/EventTaskMapper.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...onductor/core/execution/mapper/HTTPTaskMapper.java 100% <100%> (ø) 5 <0> (ø) ⬇️
.../netflix/conductor/core/execution/tasks/Event.java 88.13% <100%> (+0.63%) 12 <1> (+1) ⬆️
...om/netflix/conductor/grpc/AbstractProtoMapper.java 39.06% <66.66%> (+0.09%) 54 <0> (ø) ⬇️
...nductor/common/metadata/workflow/WorkflowTask.java 68.51% <71.42%> (+0.08%) 86 <2> (+2) ⬆️
...uctor/core/execution/tasks/WorkflowSystemTask.java 75% <75%> (ø) 10 <2> (+2) ⬆️
.../java/com/netflix/conductor/service/Lifecycle.java 30% <0%> (-30%) 2% <0%> (-1%)
.../com/netflix/conductor/grpc/server/GRPCServer.java 78.57% <0%> (-14.29%) 4% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc13b0...c598881. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2609

  • 27 of 28 (96.43%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 69.066%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/main/java/com/netflix/conductor/common/metadata/workflow/WorkflowTask.java 6 7 85.71%
Totals Coverage Status
Change from base Build 2594: 0.05%
Covered Lines: 9357
Relevant Lines: 13548

💛 - Coveralls

@milongapau milongapau changed the base branch from master to dev April 29, 2019 16:24
@kishorebanala kishorebanala changed the title MWI-1082: add async complete option to tasks EVENT and HTTP add async complete option to tasks EVENT and HTTP Apr 29, 2019
@milongapau milongapau merged commit 78fae0e into dev Apr 29, 2019
@apanicker-nflx apanicker-nflx deleted the feature/MWI-1082-update-system-tasks branch May 24, 2019 22:53
long-64 pushed a commit to long-64/conductor that referenced this pull request Oct 2, 2019
…system-tasks

add async complete option to tasks EVENT and HTTP
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants