Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

fix task scheduling and state evaluation #1171

Merged
merged 1 commit into from May 31, 2019
Merged

Conversation

apanicker-nflx
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #1171 into dev will decrease coverage by 0.01%.
The diff coverage is 91.3%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1171      +/-   ##
============================================
- Coverage     63.28%   63.27%   -0.02%     
+ Complexity     2659     2656       -3     
============================================
  Files           233      233              
  Lines         13268    13270       +2     
  Branches       1332     1331       -1     
============================================
- Hits           8397     8396       -1     
- Misses         4148     4149       +1     
- Partials        723      725       +2
Impacted Files Coverage Δ Complexity Δ
...onductor/common/metadata/workflow/WorkflowDef.java 80.64% <100%> (-0.41%) 36 <1> (-1)
...ix/conductor/core/events/SimpleEventProcessor.java 69.76% <50%> (-0.32%) 26 <0> (ø)
...tflix/conductor/core/execution/DeciderService.java 85.66% <94.44%> (-0.24%) 97 <15> (-1)
...tflix/conductor/core/execution/SystemTaskType.java 85.71% <0%> (-7.15%) 5% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad96b2a...9e6a808. Read the comment docs.

@coveralls
Copy link

coveralls commented May 30, 2019

Pull Request Test Coverage Report for Build 2745

  • 22 of 23 (95.65%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 69.191%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/main/java/com/netflix/conductor/core/events/SimpleEventProcessor.java 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
redis-persistence/src/main/java/com/netflix/conductor/jedis/JedisMock.java 2 11.44%
Totals Coverage Status
Change from base Build 2723: -0.02%
Covered Lines: 9394
Relevant Lines: 13577

💛 - Coveralls

});
boolean allCompletedSuccessfully = workflowTasks.stream()
.parallel()
.allMatch(wftask -> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@apanicker-nflx apanicker-nflx merged commit b231e27 into dev May 31, 2019
@apanicker-nflx apanicker-nflx deleted the fix_task_scheduling branch May 31, 2019 01:00
long-64 pushed a commit to long-64/conductor that referenced this pull request Oct 2, 2019
fix task scheduling and state evaluation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants