Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

added concurrent execution limit impl to C* module #1330

Merged
merged 1 commit into from Sep 27, 2019

Conversation

apanicker-nflx
Copy link
Collaborator

@apanicker-nflx apanicker-nflx commented Sep 26, 2019

  • Added a task_def_limit table to track in progress tasks for a given task definition

@coveralls
Copy link

coveralls commented Sep 26, 2019

Pull Request Test Coverage Report for Build 3079

  • 55 of 73 (75.34%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 69.999%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraExecutionDAO.java 32 50 64.0%
Totals Coverage Status
Change from base Build 3073: 0.03%
Covered Lines: 9921
Relevant Lines: 14173

💛 - Coveralls

@apanicker-nflx apanicker-nflx force-pushed the cassandra_concurrent_exec_limit branch 2 times, most recently from 7c0c286 to 39c1c75 Compare September 27, 2019 01:13
@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #1330 into dev will increase coverage by 0.02%.
The diff coverage is 68.49%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1330      +/-   ##
============================================
+ Coverage     64.09%   64.12%   +0.02%     
- Complexity     2760     2773      +13     
============================================
  Files           238      238              
  Lines         13796    13865      +69     
  Branches       1368     1375       +7     
============================================
+ Hits           8843     8891      +48     
- Misses         4204     4220      +16     
- Partials        749      754       +5
Impacted Files Coverage Δ Complexity Δ
...in/java/com/netflix/conductor/util/Statements.java 100% <100%> (ø) 18 <3> (+3) ⬆️
...flix/conductor/dao/cassandra/CassandraBaseDAO.java 86.15% <100%> (+1.67%) 12 <1> (+1) ⬆️
...tflix/conductor/common/metadata/tasks/TaskDef.java 83.67% <100%> (ø) 41 <2> (ø) ⬇️
...conductor/dao/cassandra/CassandraExecutionDAO.java 61.16% <54%> (-1.13%) 44 <10> (+9)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2982c44...e5797b5. Read the comment docs.

@apanicker-nflx apanicker-nflx force-pushed the cassandra_concurrent_exec_limit branch 2 times, most recently from f0426d7 to ccf856a Compare September 27, 2019 18:12
@apanicker-nflx apanicker-nflx merged commit 5c879de into dev Sep 27, 2019
@apanicker-nflx apanicker-nflx deleted the cassandra_concurrent_exec_limit branch September 27, 2019 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants