Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

fix exceptions and errors for invalid inputs in cassandra execution dao #1366

Merged
merged 1 commit into from Oct 26, 2019

Conversation

apanicker-nflx
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3268

  • 23 of 23 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 70.253%

Totals Coverage Status
Change from base Build 3256: 0.03%
Covered Lines: 10290
Relevant Lines: 14647

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Merging #1366 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1366      +/-   ##
============================================
- Coverage     64.39%   64.39%   -0.01%     
+ Complexity     2851     2850       -1     
============================================
  Files           241      241              
  Lines         14324    14338      +14     
  Branches       1410     1410              
============================================
+ Hits           9224     9233       +9     
- Misses         4320     4325       +5     
  Partials        780      780
Impacted Files Coverage Δ Complexity Δ
...conductor/dao/cassandra/CassandraExecutionDAO.java 63.19% <100%> (+1.75%) 45 <2> (ø) ⬇️
.../java/com/netflix/conductor/service/Lifecycle.java 30% <0%> (-30%) 2% <0%> (-1%)
.../com/netflix/conductor/grpc/server/GRPCServer.java 78.57% <0%> (-14.29%) 4% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b5ca23...f2aaf1e. Read the comment docs.

@apanicker-nflx apanicker-nflx merged commit 5530e06 into dev Oct 26, 2019
@apanicker-nflx apanicker-nflx deleted the cassandra_execution_dao_invalid_checks branch October 26, 2019 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants