Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

change dynoJedisClient builder initialization with new dyno-queues version #1374

Merged
merged 1 commit into from Nov 5, 2019

Conversation

apanicker-nflx
Copy link
Collaborator

@apanicker-nflx apanicker-nflx commented Nov 5, 2019

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3312

  • 0 of 12 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 70.024%

Changes Missing Coverage Covered Lines Changed/Added Lines %
redis-persistence/src/main/java/com/netflix/conductor/dyno/RedisQueuesDiscoveryProvider.java 0 1 0.0%
redis-persistence/src/main/java/com/netflix/conductor/dao/dynomite/queue/DynoQueueDAO.java 0 11 0.0%
Totals Coverage Status
Change from base Build 3297: -0.009%
Covered Lines: 10262
Relevant Lines: 14655

💛 - Coveralls

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #1374 into dev will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev   #1374      +/-   ##
===========================================
- Coverage     64.24%   64.2%   -0.05%     
  Complexity     2846    2846              
===========================================
  Files           241     241              
  Lines         14337   14346       +9     
  Branches       1405    1405              
===========================================
  Hits           9211    9211              
- Misses         4352    4361       +9     
  Partials        774     774
Impacted Files Coverage Δ Complexity Δ
...lix/conductor/dao/dynomite/queue/DynoQueueDAO.java 56.75% <0%> (-5.01%) 24 <0> (ø)
...x/conductor/dyno/RedisQueuesDiscoveryProvider.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9277d38...3382f2b. Read the comment docs.

@apanicker-nflx apanicker-nflx changed the title change dynoJedisClient builder initialization with new dyno-queues ve… change dynoJedisClient builder initialization with new dyno-queues version Nov 5, 2019
@apanicker-nflx apanicker-nflx merged commit ef90598 into dev Nov 5, 2019
@apanicker-nflx apanicker-nflx deleted the dyno_upgrade_fix branch November 5, 2019 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants