Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Cleanup to support generic queue implementations. #1481

Merged
merged 3 commits into from Jan 24, 2020

Conversation

kishorebanala
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #1481 into dev will increase coverage by 3.22%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1481      +/-   ##
============================================
+ Coverage     64.21%   67.44%   +3.22%     
- Complexity     3199     3983     +784     
============================================
  Files           262      269       +7     
  Lines         15634    18502    +2868     
  Branches       1553     1960     +407     
============================================
+ Hits          10039    12478    +2439     
- Misses         4760     5146     +386     
- Partials        835      878      +43
Impacted Files Coverage Δ Complexity Δ
...tflix/conductor/core/execution/DeciderService.java 89.3% <ø> (+1.54%) 143 <0> (+34) ⬆️
.../main/java/com/netflix/conductor/dao/QueueDAO.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...nductor/core/orchestration/ExecutionDAOFacade.java 55.82% <100%> (+6.4%) 48 <1> (+12) ⬆️
...lix/conductor/core/execution/WorkflowExecutor.java 78.3% <100%> (+0.23%) 147 <0> (+1) ⬆️
...uctor/core/execution/tasks/WorkflowSystemTask.java 86.95% <0%> (-4.35%) 12% <0%> (-1%)
...onductor/common/metadata/workflow/WorkflowDef.java 77.38% <0%> (-3.27%) 58% <0%> (+22%)
...tflix/conductor/common/metadata/tasks/TaskDef.java 82.09% <0%> (-1.58%) 66% <0%> (+25%)
...n/java/com/netflix/conductor/metrics/Monitors.java 67.16% <0%> (-1.07%) 54% <0%> (+17%)
...om/netflix/conductor/service/ExecutionService.java 37.45% <0%> (-0.11%) 39% <0%> (+11%)
...m/netflix/conductor/common/metadata/Auditable.java 100% <0%> (ø) 22% <0%> (+11%) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b7f28a...8a212c6. Read the comment docs.

@kishorebanala kishorebanala merged commit ad5fd09 into dev Jan 24, 2020
@kishorebanala kishorebanala deleted the cleanup_to_support_generic_queue_implementations branch January 24, 2020 02:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants