Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Default workflow archiving module #1565

Conversation

pavelhalabala
Copy link
Contributor

Implements issue #1563

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #1565 into dev will increase coverage by 0.01%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1565      +/-   ##
============================================
+ Coverage     65.03%   65.04%   +0.01%     
- Complexity     3419     3425       +6     
============================================
  Files           266      268       +2     
  Lines         16003    16017      +14     
  Branches       1444     1445       +1     
============================================
+ Hits          10407    10419      +12     
- Misses         4868     4870       +2     
  Partials        728      728
Impacted Files Coverage Δ Complexity Δ
...ix/conductor/contribs/ArchivingWorkflowModule.java 0% <0%> (ø) 0 <0> (?)
...ribs/listener/ArchivingWorkflowStatusListener.java 100% <100%> (ø) 4 <4> (?)
...tflix/conductor/core/execution/DeciderService.java 87.1% <0%> (+0.32%) 115% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa97e7d...07b93a2. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 6, 2020

Pull Request Test Coverage Report for Build 3793

  • 10 of 13 (76.92%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 69.99%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contribs/src/main/java/com/netflix/conductor/contribs/ArchivingWorkflowModule.java 0 3 0.0%
Totals Coverage Status
Change from base Build 3788: 0.006%
Covered Lines: 11428
Relevant Lines: 16328

💛 - Coveralls

Copy link
Collaborator

@apanicker-nflx apanicker-nflx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a few lines to the documentation so that other interested users in the community can avail this module for performing archival/cleanup.

@pavelhalabala pavelhalabala force-pushed the feature/archiving-workflow-status-listener branch from d2a70e4 to 07b93a2 Compare March 8, 2020 10:30
@pavelhalabala
Copy link
Contributor Author

Review comments were applied

@apanicker-nflx apanicker-nflx merged commit fbb0bba into Netflix:dev Mar 8, 2020
@pavelhalabala pavelhalabala deleted the feature/archiving-workflow-status-listener branch March 9, 2020 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants