Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

cassandra metadata dao modifications #1567

Merged
merged 2 commits into from Mar 11, 2020

Conversation

apanicker-nflx
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #1567 into dev will decrease coverage by 0.11%.
The diff coverage is 49.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1567      +/-   ##
============================================
- Coverage     65.07%   64.95%   -0.12%     
+ Complexity     3432     3424       -8     
============================================
  Files           268      268              
  Lines         16019    16025       +6     
  Branches       1446     1443       -3     
============================================
- Hits          10424    10409      -15     
- Misses         4869     4895      +26     
+ Partials        726      721       -5
Impacted Files Coverage Δ Complexity Δ
...ix/conductor/dao/postgres/PostgresMetadataDAO.java 76.11% <ø> (+0.3%) 63 <0> (-2) ⬇️
.../netflix/conductor/dao/mysql/MySQLMetadataDAO.java 81.66% <ø> (+0.48%) 65 <0> (-2) ⬇️
...tflix/conductor/dao/dynomite/RedisMetadataDAO.java 89.06% <ø> (-0.34%) 34 <0> (ø)
...in/java/com/netflix/conductor/util/Statements.java 100% <100%> (ø) 33 <1> (+1) ⬆️
.../conductor/dao/cassandra/CassandraMetadataDAO.java 54.73% <31.42%> (-10.44%) 24 <1> (-5)
...netflix/conductor/service/MetadataServiceImpl.java 73.01% <80%> (+0.13%) 17 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5379d63...56f3322. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 8, 2020

Pull Request Test Coverage Report for Build 3799

  • 25 of 51 (49.02%) changed or added relevant lines in 3 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 69.852%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/main/java/com/netflix/conductor/service/MetadataServiceImpl.java 8 10 80.0%
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java 11 35 31.43%
Files with Coverage Reduction New Missed Lines %
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java 12 55.79%
Totals Coverage Status
Change from base Build 3795: -0.1%
Covered Lines: 11411
Relevant Lines: 16336

💛 - Coveralls

@apanicker-nflx apanicker-nflx force-pushed the set_metadata_time_service_layer branch from 1327400 to 56f3322 Compare March 8, 2020 22:35
@apanicker-nflx apanicker-nflx changed the title set time for metadata defs in service layer cassandra metadata dao modifications Mar 8, 2020
@apanicker-nflx apanicker-nflx merged commit eef7f45 into dev Mar 11, 2020
@apanicker-nflx apanicker-nflx deleted the set_metadata_time_service_layer branch March 11, 2020 01:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants