Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

fix input param replacement when workflow is retried #1747

Merged
merged 1 commit into from Jun 23, 2020

Conversation

apanicker-nflx
Copy link
Collaborator

@apanicker-nflx apanicker-nflx commented Jun 22, 2020

  • Fixed input param replacement in the retried tasks when a workflow a retried
  • Allow TIMED_OUT tasks (hence the workflows) to be retried

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #1747 into dev will decrease coverage by 0.05%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1747      +/-   ##
============================================
- Coverage     64.92%   64.86%   -0.06%     
+ Complexity     3780     3764      -16     
============================================
  Files           292      289       -3     
  Lines         17931    17879      -52     
  Branches       1622     1618       -4     
============================================
- Hits          11642    11598      -44     
+ Misses         5470     5465       -5     
+ Partials        819      816       -3     
Impacted Files Coverage Δ Complexity Δ
...onductor/core/execution/tasks/ExecutionConfig.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...lix/conductor/core/execution/WorkflowExecutor.java 79.83% <85.71%> (+0.38%) 176.00 <1.00> (+2.00)
...tflix/conductor/dao/postgres/PostgresQueueDAO.java 81.73% <0.00%> (-2.48%) 45.00% <0.00%> (-1.00%)
...com/netflix/conductor/dao/RedisWorkflowModule.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
...om/netflix/conductor/dyno/RedisQueuesProvider.java 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
...lix/conductor/dao/dynomite/queue/DynoQueueDAO.java 57.79% <0.00%> (ø) 24.00% <0.00%> (ø%)
...ctor/dyno/RedisQueuesShardingStrategyProvider.java
...om/netflix/conductor/core/utils/LocalOnlyLock.java
...flix/conductor/core/utils/LocalOnlyLockModule.java
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3cd3ba...0e0e843. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4258

  • 13 of 14 (92.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 69.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java 13 14 92.86%
Totals Coverage Status
Change from base Build 4246: 0.01%
Covered Lines: 12420
Relevant Lines: 17879

💛 - Coveralls

@apanicker-nflx apanicker-nflx merged commit 5ebdd7f into dev Jun 23, 2020
@apanicker-nflx apanicker-nflx deleted the param_replacement_retry_fix branch June 23, 2020 00:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants