Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

fix sync system task execution handling; trigger failure workflow from terminate task; fix large payload retry in client #1759

Merged
merged 1 commit into from Jul 1, 2020

Conversation

apanicker-nflx
Copy link
Collaborator

@apanicker-nflx apanicker-nflx commented Jun 30, 2020

No description provided.

@apanicker-nflx apanicker-nflx changed the title fix sync system task execution handling; trigger failure workflow fro… fix sync system task execution handling; trigger failure workflow from terminate task Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #1759 into dev will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1759      +/-   ##
============================================
+ Coverage     65.03%   65.06%   +0.03%     
- Complexity     3782     3786       +4     
============================================
  Files           292      292              
  Lines         17935    17932       -3     
  Branches       1622     1622              
============================================
+ Hits          11664    11668       +4     
+ Misses         5453     5450       -3     
+ Partials        818      814       -4     
Impacted Files Coverage Δ Complexity Δ
...ix/conductor/common/metadata/tasks/TaskResult.java 86.41% <ø> (-2.61%) 26.00 <0.00> (-1.00)
...lix/conductor/core/execution/WorkflowExecutor.java 80.32% <100.00%> (+0.48%) 178.00 <0.00> (+2.00)
...com/netflix/conductor/service/WorkflowMonitor.java 68.88% <0.00%> (+2.22%) 6.00% <0.00%> (+1.00%)
.../com/netflix/conductor/dao/mysql/MySQLBaseDAO.java 71.59% <0.00%> (+4.54%) 19.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72197ae...fddef78. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 30, 2020

Pull Request Test Coverage Report for Build 4297

  • 16 of 21 (76.19%) changed or added relevant lines in 2 files are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 69.525%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/src/main/java/com/netflix/conductor/client/http/TaskClient.java 2 7 28.57%
Files with Coverage Reduction New Missed Lines %
common/src/main/java/com/netflix/conductor/common/metadata/tasks/TaskResult.java 2 86.42%
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraEventHandlerDAO.java 8 68.42%
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java 8 55.44%
Totals Coverage Status
Change from base Build 4283: -0.1%
Covered Lines: 12470
Relevant Lines: 17936

💛 - Coveralls

@apanicker-nflx apanicker-nflx force-pushed the bug_fixes branch 2 times, most recently from d2f0add to a39095a Compare June 30, 2020 20:07
@apanicker-nflx apanicker-nflx changed the title fix sync system task execution handling; trigger failure workflow from terminate task fix sync system task execution handling; trigger failure workflow from terminate task; fix large payload retry in client Jun 30, 2020
…m terminate task; fix large payload retry in client
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants