Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

convert junit tests to spock specs #1786

Merged
merged 1 commit into from Jul 18, 2020
Merged

convert junit tests to spock specs #1786

merged 1 commit into from Jul 18, 2020

Conversation

apanicker-nflx
Copy link
Collaborator

Following tests are converted:

  • Workflow with no tasks
  • Task def template

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #1786 into dev will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1786      +/-   ##
============================================
+ Coverage     64.76%   64.78%   +0.02%     
- Complexity     3794     3796       +2     
============================================
  Files           295      295              
  Lines         18085    18085              
  Branches       1627     1627              
============================================
+ Hits          11712    11716       +4     
+ Misses         5554     5551       -3     
+ Partials        819      818       -1     
Impacted Files Coverage Δ Complexity Δ
...netflix/conductor/contribs/queue/QueueManager.java 60.20% <0.00%> (+4.08%) 16.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33b96b...00a071f. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 16, 2020

Pull Request Test Coverage Report for Build 4351

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 69.24%

Files with Coverage Reduction New Missed Lines %
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraEventHandlerDAO.java 8 68.42%
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java 10 55.44%
Totals Coverage Status
Change from base Build 4347: -0.08%
Covered Lines: 12522
Relevant Lines: 18085

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants