Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Changes that allow event processor to be extended #1891

Merged
merged 2 commits into from Sep 30, 2020

Conversation

aravindanr
Copy link
Collaborator

  1. Bindings for Event related classes, like EventProvider, EventQueueProvider and ActionProcessor are moved to a different module.

  2. Methods in SimpleEventProcessor are protected to allow for extension by inheritance.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1891 into master will decrease coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1891      +/-   ##
============================================
- Coverage     65.11%   65.11%   -0.01%     
- Complexity     3891     3892       +1     
============================================
  Files           299      300       +1     
  Lines         18451    18455       +4     
  Branches       1684     1684              
============================================
+ Hits          12015    12017       +2     
- Misses         5606     5607       +1     
- Partials        830      831       +1     
Impacted Files Coverage Δ Complexity Δ
.../com/netflix/conductor/core/config/CoreModule.java 100.00% <ø> (ø) 22.00 <0.00> (-1.00)
...ix/conductor/core/events/SimpleEventProcessor.java 68.88% <0.00%> (-0.52%) 26.00 <0.00> (ø)
...com/netflix/conductor/core/config/EventModule.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...ava/com/netflix/conductor/server/ServerModule.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...x/conductor/common/metadata/tasks/TaskExecLog.java 80.95% <0.00%> (-4.77%) 11.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155a66e...cf6ad80. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 28, 2020

Pull Request Test Coverage Report for Build 4588

  • 7 of 8 (87.5%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 69.64%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/main/java/com/netflix/conductor/core/events/SimpleEventProcessor.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java 2 59.59%
Totals Coverage Status
Change from base Build 4559: 0.08%
Covered Lines: 12852
Relevant Lines: 18455

💛 - Coveralls

@aravindanr aravindanr closed this Sep 30, 2020
@aravindanr aravindanr reopened this Sep 30, 2020
@aravindanr aravindanr merged commit cdc7db8 into master Sep 30, 2020
@apanicker-nflx apanicker-nflx deleted the allow_event_processor_extension branch November 24, 2020 23:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants