implemente QueueDAO.containsMessage() for mysql and postgres. linked issue: 1892

[Yingsheng-eroad]

No description provided.

[Yingsheng-eroad]

#1892

[kishorebanala]

Hey @mashurex @jvemugunta Can you help review these MySQL / Postgres module changes please?

[james-deee]

Looks good to me. Thanks for fixing for Mysql and Postgres.

[codecov]

Codecov Report

Merging #1899 into dev will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #1899      +/-   ##
============================================
- Coverage     65.13%   64.97%   -0.16%     
- Complexity     3893     3897       +4     
============================================
  Files           300      301       +1     
  Lines         18455    18488      +33     
  Branches       1684     1684              
============================================
- Hits          12020    12013       -7     
- Misses         5605     5646      +41     
+ Partials        830      829       -1     

Impacted Files	Coverage Δ	Complexity Δ
...com/netflix/conductor/dao/mysql/MySQLQueueDAO.java	85.60% <100.00%> (+0.35%)	51.00 <2.00> (+2.00)
...tflix/conductor/dao/postgres/PostgresQueueDAO.java	91.12% <100.00%> (+0.21%)	54.00 <2.00> (+2.00)
...ductor/dao/cassandra/CassandraEventHandlerDAO.java	65.78% <0.00%> (-14.48%)	15.00% <0.00%> (-1.00%)
.../main/java/com/netflix/conductor/dao/QueueDAO.java	42.85% <0.00%> (-14.29%)	1.00% <0.00%> (-1.00%)
.../conductor/dao/cassandra/CassandraMetadataDAO.java	53.88% <0.00%> (-5.70%)	24.00% <0.00%> (-1.00%)
...x/conductor/dao/postgres/PostgresExecutionDAO.java	71.30% <0.00%> (-2.05%)	115.00% <0.00%> (ø%)
...netflix/conductor/dao/mysql/MySQLExecutionDAO.java	61.28% <0.00%> (-1.76%)	98.00% <0.00%> (ø%)
...nductor/core/orchestration/ExecutionDAOFacade.java	48.54% <0.00%> (-0.24%)	40.00% <0.00%> (ø%)
...ava/com/netflix/conductor/server/JerseyModule.java	90.90% <0.00%> (ø)	5.00% <0.00%> (-1.00%)
...in/java/com/netflix/conductor/dao/PollDataDAO.java	100.00% <0.00%> (ø)	1.00% <0.00%> (?%)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc7db8...908f966. Read the comment docs.

[coveralls]

Pull Request Test Coverage Report for Build 4612

• 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
• 23 unchanged lines in 5 files lost coverage.
• Overall coverage decreased (-0.1%) to 69.494%

---

Files with Coverage Reduction	New Missed Lines	%
core/src/main/java/com/netflix/conductor/dao/QueueDAO.java	1	42.86%
server/src/main/java/com/netflix/conductor/server/JerseyModule.java	1	95.45%
mysql-persistence/src/main/java/com/netflix/conductor/dao/mysql/MySQLBaseDAO.java	3	69.32%
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraEventHandlerDAO.java	8	68.42%
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java	10	55.44%

Totals
Change from base Build 4599:	-0.1%
Covered Lines:	12848
Relevant Lines:	18488

---

💛 - Coveralls

[mashurex]

It looks good to me as well.

[kishorebanala]

Thank you @Yingsheng-eroad @mashurex and @demichej