-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
Codecov Report
@@ Coverage Diff @@
## dev #1911 +/- ##
============================================
- Coverage 65.76% 64.98% -0.78%
- Complexity 4091 4113 +22
============================================
Files 310 316 +6
Lines 19270 19574 +304
Branches 1758 1792 +34
============================================
+ Hits 12673 12721 +48
- Misses 5730 5980 +250
- Partials 867 873 +6
Continue to review full report at Codecov.
|
Note that one test failed that has nothing to do with my changes: com.netflix.conductor.test.integration.ExternalPayloadStorageSpec. Not sure what to do about that. |
…re/kafka-event-source
…re/kafka-event-source
contribs/src/main/java/com/netflix/conductor/contribs/kafka/KafkaLoginModule.java
Show resolved
Hide resolved
…re/kafka-event-source
@aravindanr somehow I clicked on something that got rid of your question about the KafkaLoginModule class. Sorry, not sure what happened. The KafkaLoginModule class can be referenced in a JAAS configuration file to allow adding JAAS security for access to the Kafka topic. Please see example files under src/main/resources in contribs. The 'kafka.default.jaas.config.file' or 'kafka.events.jaas.config.file' property can be specified that will point to the location of the JAAS config file and that JAAS config file can include a reference to the KafkaLoginModule class which will allow for secure access to the topic. I don't know of any other way to provide secure access although i have only used Kafka at my current employer and that is the way they require that security be done for Kafka. If you look at the init() method of KafkaObservableQueue you will see the reference to config.getKafkaEventsJaasConfigFile(). If found it will set the java.security.auth.login.config system property. |
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
…re/kafka-event-source
This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days. |
This PR was closed, because it has been stalled for 7 days with no activity. |
Allow messages to be published to a Kafka topic. That Kafka topic will be used as a source for generating Conductor events to start workflows, fail tasks and complete tasks. The original implementation was taken from PR #672 which was never completed and code was added to handle secure topics, error processing and multiple consumers per topic.
Documentation on how to use it is in docs/docs/kafkaeventsource.md.