Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

ensure cancel tasks when workflow is terminated #1994

Merged
merged 1 commit into from Dec 3, 2020

Conversation

apanicker-nflx
Copy link
Collaborator

No description provided.

@apanicker-nflx apanicker-nflx force-pushed the ensure_cancel_task_terminate_workflow branch from 5e3c223 to 38c56f5 Compare December 2, 2020 23:59
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #1994 (38c56f5) into dev (ea9ad82) will increase coverage by 0.02%.
The diff coverage is 65.51%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1994      +/-   ##
============================================
+ Coverage     65.61%   65.64%   +0.02%     
- Complexity     3947     3953       +6     
============================================
  Files           301      301              
  Lines         18562    18574      +12     
  Branches       1698     1701       +3     
============================================
+ Hits          12179    12192      +13     
+ Misses         5543     5542       -1     
  Partials        840      840              
Impacted Files Coverage Δ Complexity Δ
...tflix/conductor/core/execution/DeciderService.java 87.10% <0.00%> (ø) 129.00 <0.00> (+1.00)
...lix/conductor/core/execution/WorkflowExecutor.java 80.00% <67.85%> (-0.20%) 184.00 <4.00> (+2.00) ⬇️
...e/execution/tasks/SystemTaskWorkerCoordinator.java 83.33% <0.00%> (+2.08%) 18.00% <0.00%> (+1.00%)
.../com/netflix/conductor/dao/mysql/MySQLBaseDAO.java 72.22% <0.00%> (+4.44%) 20.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e422baf...38c56f5. Read the comment docs.

@apanicker-nflx apanicker-nflx merged commit 954c9a8 into dev Dec 3, 2020
@apanicker-nflx apanicker-nflx deleted the ensure_cancel_task_terminate_workflow branch December 3, 2020 18:09
pmchung pushed a commit to routific/conductor that referenced this pull request Sep 6, 2023
…nate_workflow

ensure cancel tasks when workflow is terminated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants