Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

backported fix for termiante task from #2056 #2093

Merged
merged 1 commit into from Feb 22, 2021

Conversation

apanicker-nflx
Copy link
Collaborator

Backported fix from #2056

@apanicker-nflx
Copy link
Collaborator Author

@rickfish Please verify the changes made to the TERMINATE task here as per #2056. Pinging as per this comment.
Please let me know if you find any discrepancies.

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #2093 (e07a7c1) into dev (bf8a5fd) will increase coverage by 0.04%.
The diff coverage is 82.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2093      +/-   ##
============================================
+ Coverage     65.75%   65.79%   +0.04%     
- Complexity     4074     4083       +9     
============================================
  Files           308      308              
  Lines         19224    19236      +12     
  Branches       1756     1759       +3     
============================================
+ Hits          12640    12656      +16     
+ Misses         5720     5715       -5     
- Partials        864      865       +1     
Impacted Files Coverage Δ Complexity Δ
...nductor/common/metadata/workflow/WorkflowTask.java 79.36% <ø> (ø) 98.00 <0.00> (ø)
...flix/conductor/core/execution/tasks/Terminate.java 100.00% <ø> (ø) 12.00 <0.00> (-2.00)
...onductor/core/execution/WorkflowRepairService.java 69.23% <50.00%> (-1.04%) 13.00 <0.00> (ø)
...tflix/conductor/core/execution/DeciderService.java 87.05% <68.75%> (-0.05%) 137.00 <5.00> (+8.00) ⬇️
...lix/conductor/core/execution/WorkflowExecutor.java 80.33% <87.09%> (+0.24%) 190.00 <5.00> (-2.00) ⬆️
...onductor/common/metadata/workflow/WorkflowDef.java 85.96% <100.00%> (+0.37%) 47.00 <9.00> (+2.00)
...ix/conductor/core/execution/tasks/SubWorkflow.java 97.53% <100.00%> (+0.09%) 27.00 <0.00> (+1.00)
.../conductor/dao/cassandra/CassandraMetadataDAO.java 55.44% <0.00%> (+1.55%) 25.00% <0.00%> (+1.00%)
...e/execution/tasks/SystemTaskWorkerCoordinator.java 83.33% <0.00%> (+2.08%) 18.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf8a5fd...e07a7c1. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5076

  • 54 of 56 (96.43%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 70.311%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java 30 31 96.77%
core/src/main/java/com/netflix/conductor/core/execution/WorkflowRepairService.java 1 2 50.0%
Totals Coverage Status
Change from base Build 5064: 0.03%
Covered Lines: 13525
Relevant Lines: 19236

💛 - Coveralls

@apanicker-nflx apanicker-nflx merged commit 75300d6 into dev Feb 22, 2021
@apanicker-nflx apanicker-nflx deleted the backport_terminate_task_fix branch February 22, 2021 23:15
@apanicker-nflx apanicker-nflx removed this from To do in New Issues Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants