This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Removed TaskType#isSystemTask in favor SystemTaskRegistry#isSystemTask #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Code consolidation: The check to find if a task is a system task existed in two places. SystemTaskRegistry and TaskType. TaskType only considered hardcoded tasks as system tasks whereas SystemTaskRegistry considered any instance of WorkflowSystemTask. Replacing the TaskType#isSystemTask with SystemTaskRegistry#isSystemTask fixes the possibility that some code is only executed hardcoded system tasks and not all. In places where TaskType#isSystemTask is used as a litmus test in task type String to Enum conversion, a new method TaskType#of is used.