Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Migrate conductor JAXB dependency from javax. to jakarta #2497

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

taoj-action
Copy link
Contributor

The conductor has JAXB dependency on javax.* which should be migrated
to jakarta.*.

Signed-off-by: Tao Jiang taoj@vmware.com

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

The conductor has JAXB dependency on javax.* which should be migrated to jakarta.* due to some legal issues. We, VMware, use and build the conductor as a library into our own service for internal CI/CD requirements. This change will also avoid library clashes.

Describe the new behavior from this PR, and why it's needed
Issue #2495

Alternatives considered

Deploy vanilla Conductor as standalone service. However, we have totally replaced the API layer with our own implementation in order to support using ASL (Amazon State Language) as DSL and security enhancement. It will be much less efficient to keep the conductor's API layer.

Describe alternative implementation you have considered

The conductor has JAXB dependency on javax.* which should be migrated
to jakarta.*.

Signed-off-by: Tao Jiang <taoj@vmware.com>
@aravindanr
Copy link
Collaborator

aravindanr commented Oct 1, 2021

hello @taojwmware thanks for the pull request. You mentioned that VMWare uses Amazon State Language as DSL with Conductor. This reminded me of a discussion #2215 you and i had a while ago. If you can share details about how you adapted ASL, it would be beneficial to the community. Also, we would be happy to discuss if you want to contribute your implementation to the Conductor project.

@taoj-action
Copy link
Contributor Author

@aravindanr Thanks for taking a look. We internally replaced conductor-rest with custom-rest which translates ASL into Conductor DSL on the fly. My teammate @venkag designs and implements that including an extensible evaluator. Certainly, we are more than happy to contribute back to the community.

@aravindanr aravindanr added the type: dependencies Pull requests that update a dependency file label Oct 5, 2021
@aravindanr
Copy link
Collaborator

That would be great. @venkag if you like to contribute your adapter, please start a discussion so the rest of the community has visibility.

@aravindanr aravindanr merged commit 6d6ab5b into Netflix:main Oct 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Unit Test Results

   154 files  ±0     154 suites  ±0   8m 3s ⏱️ ±0s
1 130 tests ±0  1 130 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 6d6ab5b. ± Comparison against base commit 6d6ab5b.

@venkag
Copy link
Contributor

venkag commented Oct 5, 2021

That would be great. @venkag if you like to contribute your adapter, please start a discussion so the rest of the community has visibility.

@aravindanr The ASL to conductor DSL conversion adapter is a bit narrow that fits our needs. It needs some work (and so time) to make it generic enough for wider consumption. Will start a discussion sometime in the near future when there is something tangible.

cc: @taojwmware

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants