This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Remove guava from common module; Handle exceptions in sweeper #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bed9238
to
8c1aac8
Compare
8c1aac8
to
afde1d1
Compare
|
aravindanr
reviewed
Apr 15, 2022
core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java
Show resolved
Hide resolved
core/src/main/java/com/netflix/conductor/core/events/DefaultEventProcessor.java
Show resolved
Hide resolved
core/src/main/java/com/netflix/conductor/core/config/ConductorCoreConfiguration.java
Outdated
Show resolved
Hide resolved
92f4690
to
61425b6
Compare
I removed the retries over single request ES client calls, and only added retries on the bulk request which can have partial failures. |
83b3bfe
to
f9b3411
Compare
3183158
to
5e7c963
Compare
jxu-nflx
reviewed
Apr 21, 2022
...dra-persistence/src/main/java/com/netflix/conductor/cassandra/dao/CassandraExecutionDAO.java
Show resolved
Hide resolved
jxu-nflx
reviewed
Apr 21, 2022
client/src/main/java/com/netflix/conductor/client/automator/TaskPollExecutor.java
Show resolved
Hide resolved
jxu-nflx
reviewed
Apr 21, 2022
core/src/main/java/com/netflix/conductor/core/reconciliation/WorkflowSweeper.java
Show resolved
Hide resolved
jxu-nflx
reviewed
Apr 21, 2022
...persistence/src/main/java/com/netflix/conductor/es6/config/ElasticSearchV6Configuration.java
Outdated
Show resolved
Hide resolved
aravindanr
reviewed
Apr 21, 2022
common/src/main/java/com/netflix/conductor/common/run/Workflow.java
Outdated
Show resolved
Hide resolved
contribs/src/main/java/com/netflix/conductor/contribs/storage/S3PayloadStorage.java
Show resolved
Hide resolved
core/src/main/java/com/netflix/conductor/core/events/DefaultEventProcessor.java
Outdated
Show resolved
Hide resolved
...persistence/src/main/java/com/netflix/conductor/es6/config/ElasticSearchV6Configuration.java
Outdated
Show resolved
Hide resolved
es6-persistence/src/main/java/com/netflix/conductor/es6/dao/index/ElasticSearchRestDAOV6.java
Show resolved
Hide resolved
5e7c963
to
eb65994
Compare
jxu-nflx
approved these changes
Apr 22, 2022
eb65994
to
1f8cb88
Compare
aravindanr
reviewed
Apr 26, 2022
es6-persistence/src/main/java/com/netflix/conductor/es6/dao/index/ElasticSearchDAOV6.java
Show resolved
Hide resolved
aravindanr
approved these changes
Apr 26, 2022
1f8cb88
to
e739c34
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR