Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Remove guava from common module; Handle exceptions in sweeper #2923

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

apanicker-nflx
Copy link
Collaborator

Pull Request type

  • Bugfix
  • Refactoring (no functional changes, no api changes)

Changes in this PR

  • Removed guava from common module
  • Fixed exception handling within the sweeper

@aravindanr
Copy link
Collaborator

  1. Wherever RetryTemplate is created, i suggest that they are created with a qualifier in a Spring @Configuration class. The RetryUtil encapsulated the guava retry boilerplate from the classes that need to use them. The createRetryTemplate() method brings the boilerplate back to the classes that use it.
  2. I am not sure if we need blind retries over ES client calls, but that's a separate discussion.

@apanicker-nflx
Copy link
Collaborator Author

I am not sure if we need blind retries over ES client calls, but that's a separate discussion.

I removed the retries over single request ES client calls, and only added retries on the bulk request which can have partial failures.

@apanicker-nflx apanicker-nflx force-pushed the remove_guava branch 2 times, most recently from 83b3bfe to f9b3411 Compare April 20, 2022 06:31
@apanicker-nflx apanicker-nflx marked this pull request as ready for review April 20, 2022 06:49
@apanicker-nflx apanicker-nflx force-pushed the remove_guava branch 4 times, most recently from 3183158 to 5e7c963 Compare April 21, 2022 06:12
@apanicker-nflx apanicker-nflx added the type: maintenance Refactoring label Apr 26, 2022
@apanicker-nflx apanicker-nflx changed the title remove guava from common module;handle exceptions in sweeper Remove guava from common module; Handle exceptions in sweeper Apr 26, 2022
@apanicker-nflx apanicker-nflx merged commit 5742b13 into main Apr 26, 2022
@apanicker-nflx apanicker-nflx deleted the remove_guava branch April 26, 2022 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants